[MPlayer-dev-eng] [PATCH] dvdnav part 2 - still frames

[Ötvös Attila]

2007. augusztus 5. 12.52 dátummal Carl Eugen Hoyos ezt írta:
> Hi Attila!
>
> Ötvös Attila <oattila <at> chello.hu> writes:
> > I corretions, break long line and update to "stream_dvd_common.h".
> >
> > Remark:
> > if without track number then play full dvd menu ("dvdnav://")
> > if track number is 0 then probe skip intro, warning, etc. ("dvdnav://0")
>
> Just two remarks, I'm sorry I can't review the code:
>
> [...]
>
> > -
> > +  uint32_t nextstill;
> > +  dvdnav_still_event_t *still_event;
> > +
>
> Please try to carefully avoid cosmetics (and trailing whitespace): They
> make reviews much harder.
>
> [...]
>
> > +// FIXME: if MPlayer returns from movie to still frame
> > +//        then MPlayer can't init the video codec
> > +#if 0
>
> I wonder if Nico maybe meant *all* #if0's when he wrote "those #if0 are
> useless, better remove the enclosed code"?
>
> Carl Eugen
I correction and remove uninit and depend code.
Thanks.

Attila
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dvdnav-2.patch
Type: text/x-diff
Size: 24365 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20070805/4774bc5a/attachment.patch>