[MPlayer-dev-eng] [PATCH] dvdnav part 2 - still frames

[Carl Eugen Hoyos]

Hi Attila!

Ötvös Attila <oattila <at> chello.hu> writes:

> I corretions, break long line and update to "stream_dvd_common.h".
> 
> Remark:
> if without track number then play full dvd menu ("dvdnav://")
> if track number is 0 then probe skip intro, warning, etc. ("dvdnav://0")

Just two remarks, I'm sorry I can't review the code:

[...]

> -
> +  uint32_t nextstill;
> +  dvdnav_still_event_t *still_event;
> +

Please try to carefully avoid cosmetics (and trailing whitespace): They make
reviews much harder.

[...]

> +// FIXME: if MPlayer returns from movie to still frame
> +//        then MPlayer can't init the video codec
> +#if 0

I wonder if Nico maybe meant *all* #if0's when he wrote "those #if0 are useless,
better remove the enclosed code"?

Carl Eugen