[MPlayer-dev-eng] [PATCH] tiny cleanup in stream.h
Reimar.Doeffinger at stud.uni-karlsruhe.de
Sun Aug 5 11:16:42 CEST 2007
On Sun, Aug 05, 2007 at 10:45:10AM +0200, Nico Sabbi wrote:
> Reimar Döffinger wrote:
> > On Sun, Aug 05, 2007 at 12:23:26AM +0200, Nico Sabbi wrote:
> >> This patch removes the definitions of
> >> dvd_(title|chapter|last_chapter|title) from stream.h and moves them
> >> where they are used, cause stream.h is the interface of the stream
> >> layer rather than the thrashbin.
> >> I'll commit tomorrow unless there are reasonable objections
> > Well, just adding an extern in all these places isn't a real solution
> > either.
> > Also e.g. gui/win32/dialogs.c seems to only use dvd_title and
> > dvd_chapter, and only mkv uses dvd_last_chapter so declaring
> > all is overkill.
> I'll take the long way and reimplement the guilty code in the guis as
> calls to stream_control() (many already exist)
That would be nice, though in case you don't have the time I'm fine with
just moving the externs if you just don't add those that aren't needed,
even though it's a much inferior solution.
More information about the MPlayer-dev-eng