[MPlayer-dev-eng] [PATCH] tiny cleanup in stream.h

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Sun Aug 5 01:07:42 CEST 2007


Hello,
On Sun, Aug 05, 2007 at 12:23:26AM +0200, Nico Sabbi wrote:
>  This patch removes the definitions of
>  dvd_(title|chapter|last_chapter|title) from stream.h and moves them
>  where they are used, cause stream.h is the interface of the stream
>  layer rather than the thrashbin.
>  I'll commit tomorrow unless there are reasonable objections

Well, just adding an extern in all these places isn't a real solution
either.
Also e.g. gui/win32/dialogs.c seems to only use dvd_title and
dvd_chapter, and only mkv uses dvd_last_chapter so declaring
all is overkill.

Greetings,
Reimar Döffinger



More information about the MPlayer-dev-eng mailing list