[MPlayer-dev-eng] [PATCH] ddvnav+internal dvdread

[Nico Sabbi]

Diego Biurrun wrote:
> On Mon, Apr 30, 2007 at 11:27:22AM +0200, Nico Sabbi wrote:
> 
>>Diego Biurrun wrote:
>>
>>
>>>>or, if you prefer, I can check the whole dvdnav checking code at the 
>>>>bottom of configure (as last test)
>>>
>>>Just move the libdvdnav test after the libdvdread test and disable
>>>libdvdnav if no libdvdread is available.
>>>
>>
>>it wouldn't work: consider the case when we are configuring the build 
>>with the
>>internal dvdread (that is not yet compiled, of course) : all tests will 
>>be compiled
>>with -ldvdnavmini in the flags, but they will all fail because the 
>>dvdread symbols
>>(required by libdvdnavmini) will be missing
> 
> 
> I don't see a problem, simply skip the check for libdvdread when the
> internal libdvdread is enabled.  What am I missing?

see what happens if I leave the assignment

_ld_extra="$_ld_extra `$_dvdnavconfig --minilibs`"

in the block that tests the availability of dvdnav.
Follows an excerpt from configure.log:

============ Checking for cdparanoia ============

#include <cdda_interface.h>
#include <cdda_paranoia.h>
// This need a better test. How ?
int main(void) {
     void *test = cdda_verbose_set;
     return test == (void *)1;
}

cc -O4 -march=pentium4 -mtune=pentium4 -pipe -ffast-math 
-fomit-frame-pointer  -I/usr/X11/include  -I/usr/include/artsc 
-pthread -I/usr/inc
/usr/local/lib/libdvdnavmini.so: undefined reference to `ifoRead_VTS_ATRT'
/usr/local/lib/libdvdnavmini.so: undefined reference to `DVDCloseFile'
/usr/local/lib/libdvdnavmini.so: undefined reference to `DVDOpen'
/usr/local/lib/libdvdnavmini.so: undefined reference to 
`ifoRead_VOBU_ADMAP'
[...]
Result is: no




============ Checking for freetype >= 2.0.9 ============
cc -O4 -march=pentium4 -mtune=pentium4 -pipe -ffast-math 
-fomit-frame-pointer  -I/usr/X11/include  -I/usr/include/artsc 
-pthread -I/usr/inc
/usr/local/lib/libdvdnavmini.so: undefined reference to `ifoRead_VTS_ATRT'
/usr/local/lib/libdvdnavmini.so: undefined reference to `DVDCloseFile'
/usr/local/lib/libdvdnavmini.so: undefined reference to `DVDOpen'
/usr/local/lib/libdvdnavmini.so: undefined reference to 
`ifoRead_VOBU_ADMAP'
[...]
Result is: no


and so on for all the following tests, indipendently from the presence 
of the internal or external dvdread.


> 
> Diego
> 
> P.S.: The linebreaking of your mailer is completely broken.

I'll see how I can teach Thunderbird to behave