[MPlayer-dev-eng] [PATCH] ddvnav+internal dvdread

Nico Sabbi nicola_sabbi at fastwebnet.it
Mon Apr 30 10:59:15 CEST 2007

Diego Biurrun wrote:

>>@@ -7542,6 +7532,8 @@
>>   _libavmuxers=`echo $_libavmuxers | sed -e s/LIBNUT_MUXER// `
>> fi
>>+test "$_dvdnav" = yes && _ld_extra="$_ld_extra `$_dvdnavconfig --minilibs`"
> This is unacceptable, it belongs together with the libdvdnav test, don't
> spread things all over configure.
> Diego

it's there for a reason: libdvdnavmini depends on dvdread code, but 
it's not linked to libdvdread to permit mplayer to link either the
internal dvdread or the global library ( -ldvdread ) .
If I moved the assignment in the dvdnav checking block all the 
following tests would be performed with $_ld_extra containing 
-ldvdnavmini and would fail because of the lack of the dvdread symbols.

BTW, why do we keep on appending flags to $_ld_extra along the way
rather than only at the end?

More information about the MPlayer-dev-eng mailing list