[MPlayer-dev-eng] r23172 - in trunk/gui: interface.c mplayer/common.c mplayer/gtk/eq.c mplayer/gtk/menu.c mplayer/gtk/opts.c mplayer/gtk/url.c mplayer/menu.c mplayer/mw.c mplayer/sw.c
SciFi
sci-fi at hush.ai
Sun Apr 29 22:24:52 CEST 2007
Hi,
(Gmane won't let us post to -cvs, so I must post this to the
next-best place i.e. -devel please)
I think this commit has broken builds on darwin/osx and maybe
other platforms:
On Sun, 29 Apr 2007 14:44:34 +0200, diego wrote:
> Author: diego
> Date: Sun Apr 29 14:44:34 2007
> New Revision: 23172
>
> Log:
> Fix several implicit declarations of functions warnings.
> [...]
> Modified: trunk/gui/interface.c
> ==============================================================================
> --- trunk/gui/interface.c (original)
> +++ trunk/gui/interface.c Sun Apr 29 14:44:34 2007 @@ -46,6 +46,11 @@
> extern af_cfg_t af_cfg;
> #include "stream/stream_dvd.h"
> #endif
>
> +#ifdef HAVE_VCD
> +#include <sys/ioctl.h>
> +#include <errno.h>
> +#include "stream/vcd_read.h"
> +#endif
>
> #include "m_config.h"
> #include "m_option.h"
> [...]
Here are my console logs from ./configure and make:
>>>>
Detected operating system: Darwin
Detected host architecture: ppc
Checking for cc version ... 4.0.1, ok
Checking for host cc ... cc
Checking for cross compilation ... no
Checking for CPU type ... 970 altivec
Checking for GCC & CPU optimization abilities ... 970
Checking for assembler support of -pipe option ... no
Checking for compiler support of named assembler arguments ... yes
Checking for .align is a power of two ... yes
Checking for GCC altivec support ... Darwin-style (-faltivec -D__APPLE_ALTIVEC__)
Checking for altivec.h ... yes
Checking for extra headers ... -I/usr/local/include -Os -mpowerpc64 -mcpu=970 -mtune=970 -mpowerpc-gpopt -mpowerpc-gfxopt -mmultiple -mstring -mfused-madd -mpim-altivec -faltivec -maltivec -mabi=altivec -floop-optimize2 -fbranch-target-load-optimize2 -Wall -ffast-math -fomit-frame-pointer
Checking for extra libs ... -L/usr/local/lib -Wl,-read_only_relocs,warning -Wl,-framework,CoreServices,-framework,ApplicationServices -L/usr/local/lib -L/usr/X11R6/lib -lgtk-x11-2.0 -lgdk-x11-2.0 -lXrandr -lXrender -lXinerama -lXext -lX11 -latk-1.0 -lgdk_pixbuf-2.0 -lpangocairo-1.0 -lXcursor -lcairo -lpangoft2-1.0 -lfontconfig -lfreetype -lz -lpango-1.0 -lm -lgobject-2.0 -lgmodule-2.0 -lgthread-2.0 -lglib-2.0 -lintl -liconv
Checking for -lposix ... no
Checking for -lm ... yes
Checking for langinfo ... yes
Checking for language ... using en (man pages: en )
Checking for enable sighandler ... yes
Checking for runtime cpudetection ... no
Checking for restrict keyword ... __restrict
Checking for __builtin_expect ... yes
Checking for kstat ... no
Checking for posix4 ... no
Checking for lrintf ... yes
Checking for round ... yes
Checking for nanosleep ... yes
Checking for socklib ... yes
Checking for inet_pton() ... yes (using )
Checking for network ... yes
Checking for inttypes.h (required) ... yes
Checking for int_fastXY_t in inttypes.h ... yes
Checking for word size ... 32
Checking for stddef.h ... yes
Checking for malloc.h ... yes
Checking for memalign() ... no
Checking for alloca.h ... yes
Checking for mman.h ... yes
Checking for dynamic loader ... yes
Checking for dynamic a/v plugins support ... yes
Checking for pthread ... yes (using )
Checking for rpath ... no
Checking for iconv ... yes
Checking for sys/soundcard.h ... no
Checking for soundcard.h ... no
Checking for sys/dvdio.h ... no
Checking for sys/cdio.h ... no
Checking for linux/cdrom.h ... no
Checking for dvd.h ... no
Checking for termcap ... yes (using -lncurses -ltinfo)
Checking for termios ... yes (using sys/termios.h)
Checking for shm ... yes
Checking for linux devfs ... no
Checking for scandir() ... yes
Checking for strsep() ... yes
Checking for strlcpy() ... yes
Checking for strlcat() ... yes
Checking for fseeko() ... yes
Checking for localtime_r() ... yes
Checking for vsscanf() ... yes
Checking for swab() ... yes
Checking for POSIX select() ... yes
Checking for gettimeofday() ... yes
Checking for glob() ... yes
Checking for setenv() ... yes
Checking for sys/sysinfo.h ... no
Checking for Mac OS X APIs ... yes
Checking for Mac OS X Finder Support ... yes
Checking for Mac OS X Bundle file locations ... yes
Checking for pkg-config ... yes
Checking for Samba support (libsmbclient) ... no
Checking for 3dfx ... no
Checking for tdfxfb ... no
Checking for s3fb ... no
Checking for tdfxvid ... no
Checking for tga ... yes
Checking for DirectFB ... no
Checking for X11 headers presence ... yes (using /usr/X11R6/include)
Checking for X11 ... yes
Checking for DPMS ... yes (using Xdpms 4)
Checking for Xv ... yes
Checking for XvMC ... no
Checking for Xinerama ... yes
Checking for Xxf86vm ... yes
Checking for XF86keysym ... yes
Checking for DGA ... no
Checking for OpenGL ... yes
Checking for /dev/mga_vid ... no
Checking for xmga ... no
Checking for GGI ... no
Checking for GGI extension: libggiwmh ... no
Checking for AA ... no
Checking for CACA ... yes
Checking for SVGAlib ... no
Checking for FBDev ... no
Checking for DVB ... no
Checking for DVB HEAD ... no
Checking for PNG support ... yes
Checking for JPEG support ... yes
Checking for PNM support ... yes
Checking for GIF support ... yes
Checking for broken giflib workaround ... disabled
Checking for VESA support ... no
Checking for SDL ... yes (using /usr/local/bin/sdl-config)
Checking for NAS ... no
Checking for DXR2 ... no
Checking for DXR3/H+ ... no
Checking for IVTV TV-Out ... no
Checking for OSS Audio ... no
Checking for aRts ... no
Checking for EsounD ... yes
Checking for esd_get_latency() ... yes
Checking for Polyp ... no
Checking for JACK ... yes
Checking for OpenAL ... yes
Checking for ALSA audio ... no
Checking for Sun audio ... no
Checking for VCD support ... yes
Checking for DVD support (libdvdnav) ... yes
Checking for dvdread ... yes (from dvdnav)
Checking for internal libdvdcss ... no
Checking for cdparanoia ... yes
Checking for libcdio ... auto (using cdparanoia)
Checking for bitmap font support ... yes
Checking for freetype >= 2.0.9 ... yes
Checking for fontconfig ... yes
Checking for SSA/ASS support ... yes
Checking for fribidi with charsets ... no
Checking for ENCA ... no
Checking for zlib ... yes
Checking for RTC ... no
Checking for liblzo2 support ... yes
Checking for mad support ... yes
Checking for Twolame ... yes
Checking for Toolame ... no (disabled by twolame)
Checking for OggVorbis support ... yes (libvorbis)
Checking for libspeex (version >= 1.1 required) ... yes
Checking for OggTheora support ... yes
Checking for mp3lib support ... yes
Checking for liba52 support ... yes
Checking for libdts support ... yes
Checking for libmpeg2 support ... yes
Checking for libmpcdec (musepack, version >= 1.2.1 required) ... yes
Checking for FAAC (AAC encoder) support ... yes (in libavcodec: yes)
Checking for FAAD2 (AAC) support ... yes
Checking for LADSPA plugin support ... no
Checking for Win32 codecs ... no
Checking for XAnim codecs ... yes (using /usr/local/lib/codecs)
Checking for RealPlayer codecs ... yes (using /usr/local/lib/mplayer)
Checking for LIVE555 Streaming Media libraries ... yes (using /usr/local/lib/live)
Checking for FFmpeg libavutil ... yes (static)
Checking for FFmpeg libavcodec ... yes (static)
Checking for FFmpeg libavformat ... yes (static)
Checking for FFmpeg libpostproc ... yes (static)
Checking for md5sum support ... yes
Checking for AMR narrowband ... yes
Checking for AMR wideband ... yes
Checking for libdv-0.9.5+ ... yes
Checking for zr ... no
Checking for bl ... no
Checking for XviD ... no
Checking for x264 ... yes (in libavcodec: yes)
Checking for nut ... no
Checking for libmp3lame (for mencoder) ... yes
Checking for mencoder ... yes
Checking for fastmemcpy ... yes
Checking for UniquE RAR File Library ... yes
Checking for TV interface ... yes
Checking for Video 4 Linux TV interface ... no
Checking for Video 4 Linux 2 TV interface ... no
Checking for Radio interface ... no
Checking for Capture for Radio interface ... no
Checking for Video 4 Linux 2 Radio interface ... no
Checking for Video 4 Linux Radio interface ... no
Checking for Video 4 Linux 2 MPEG PVR interface ... no
Checking for audio select() ... yes
Checking for ftp ... yes
Checking for vstream client ... no
Checking for byte order ... big-endian
Checking for OSD menu ... yes
Checking for QuickTime codecs ... yes
Checking for Subtitles sorting ... yes
Checking for XMMS inputplugin support ... no
Checking for inet6 ... yes
Checking for gethostbyname2 ... yes
Checking for GUI ... yes
Checking for XShape extension ... yes
Checking for GTK+ version ... 2.10.11
Checking for glib version ... 2.13.0
Checking for automatic gdb attach ... no
Checking for compiler support for noexecstack ... no
Checking for ftello() ... yes
Checking for VIDIX (internal) ... no
Checking for VIDIX (external) ... no
Checking for joystick ... no
Checking for lirc ... no
Checking for lircc ... no
Checking for color console output ... yes
Creating config.mak
Creating config.h
Config files successfully generated by ./configure --with-sdl-config=/usr/local/bin/sdl-config --with-freetype-config=/usr/local/bin/freetype-config --with-dvdnav-config=/usr/local/bin/dvdnav-config --realcodecsdir=/usr/local/lib/mplayer --enable-dynamic-plugins --enable-largefiles --enable-menu --enable-altivec --enable-qtx --enable-macosx --enable-macosx-bundle --enable-macosx-finder-support --disable-faad-internal --disable-tremor-internal --enable-color-console --enable-gui --disable-debug --disable-dvdread-internal --disable-libdvdcss-internal --disable-crash-debug !
Install prefix: /usr/local
Data directory: /usr/local/share/mplayer
Config direct.: /usr/local/etc/mplayer
Byte order: big-endian
Optimizing for: 970 altivec
Languages:
Messages/GUI: en
Manual pages: en
Enabled optional drivers:
Input: ftp tv live555 cddb cdda dvdread(from dvdnav) dvdnav vcd network
Codecs: qtx x264 libdv amr_wb amr_nb libavcodec real xanim faad2 faac musepack libmpeg2 libdts liba52 mp3lib libtheora speex libvorbis twolame libmad liblzo gif
Audio output: openal jack esd sdl mpegpes(file) macosx
Video output: md5sum sdl gif89a pnm jpeg png mpegpes(file) caca opengl xv x11 xover tga macosx quartz
Audio filters:
Disabled optional drivers:
Input: vstream pvr radio tv-v4l2 tv-v4l1 libdvdcss(internal) dvb smb
Codecs: xvid win32 toolame
Audio output: sun alsa polyp arts oss ivtv dxr2 nas
Video output: xvidix winvidix cvidix bl zr zr2 ivtv dxr3 dxr2 vesa fbdev svga aa ggi xmga mga dga xvmc dfbmga directfb tdfx_vid s3fb tdfxfb 3dfx
Audio filters: ladspa
[...]
# make -w
cc -I. -I./libavutil -Wdeclaration-after-statement -I. -I.. -I../libavutil -Os -mpowerpc64 -mcpu=970 -mtune=970 -mpowerpc-gpopt -mpowerpc-gfxopt -mmultiple -mstring -mfused-madd -mpim-altivec -faltivec -maltivec -mabi=altivec -floop-optimize2 -fbranch-target-load-optimize2 -Wall -ffast-math -fomit-frame-pointer -faltivec -D__APPLE_ALTIVEC__ -mdynamic-no-pic -falign-loops=16 -DSYS_DARWIN -DCONFIG_DARWIN -shared-libgcc -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -I/usr/local/include -Os -mpowerpc64 -mcpu=970 -mtune=970 -mpowerpc-gpopt -mpowerpc-gfxopt -mmultiple -mstring -mfused-madd -mpim-altivec -faltivec -maltivec -mabi=altivec -floop-optimize2 -fbranch-target-load-optimize2 -Wall -ffast-math -fomit-frame-pointer -I/usr/X11R6/include -I/usr/local/include/ -I/usr/local/include/SDL -D_THREAD_SAFE -I/usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/include/dvdnav -I/usr/local/include/freetype2 -I/usr/local/include -I/usr/local/include -I/usr/local/include/gtk-2.0 -I/usr/local/lib/gtk-2.0/include -I/usr/local/include/atk-1.0 -I/usr/local/include/cairo -I/usr/local/include/pango-1.0 -I/usr/local/include -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/local/include/freetype2 -I/usr/local/include/libpng12 -I/usr/X11R6/include -I./libavcodec -I../libavcodec -I../libavformat -Wdeclaration-after-statement -I. -I.. -I../libavutil -Os -mpowerpc64 -mcpu=970 -mtune=970 -mpowerpc-gpopt -mpowerpc-gfxopt -mmultiple -mstring -mfused-madd -mpim-altivec -faltivec -maltivec -mabi=altivec -floop-optimize2 -fbranch-target-load-optimize2 -Wall -ffast-math -fomit-frame-pointer -faltivec -D__APPLE_ALTIVEC__ -mdynamic-no-pic -falign-loops=16 -DSYS_DARWIN -DCONFIG_DARWIN -shared-libgcc -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -I/usr/local/include -Os -mpowerpc64 -mcpu=970 -mtune=970 -mpowerpc-gpopt -mpowerpc-gfxopt -mmultiple -mstring -mfused-madd -mpim-altivec -faltivec -maltivec -mabi=altivec -floop-optimize2 -fbranch-target-load-optimize2 -Wall -ffast-math -fomit-frame-pointer -I/usr/X11R6/include -I/usr/local/include/ -I/usr/local/include/SDL -D_THREAD_SAFE -I/usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/include/dvdnav -I/usr/local/include/freetype2 -I/usr/local/include -I/usr/local/include -I/usr/local/include/gtk-2.0 -I/usr/local/lib/gtk-2.0/include -I/usr/local/include/atk-1.0 -I/usr/local/include/cairo -I/usr/local/include/pango-1.0 -I/usr/local/include -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/local/include/freetype2 -I/usr/local/include/libpng12 -I/usr/X11R6/include -Os -mpowerpc64 -mcpu=970 -mtune=970 -mpowerpc-gpopt -mpowerpc-gfxopt -mmultiple -mstring -mfused-madd -mpim-altivec -faltivec -maltivec -mabi=altivec -floop-optimize2 -fbranch-target-load-optimize2 -Wall -ffast-math -fomit-frame-pointer -c -o interface.o interface.c
In file included from interface.c:52:
../stream/vcd_read.h:243:2: error: #error vcd is not yet supported on this arch...
interface.c: In function ‘gconvert_uri_to_filename’:
interface.c:201: warning: passing argument 2 of ‘libiconv’ from incompatible pointer type
interface.c: In function ‘guiInit’:
interface.c:319: warning: pointer targets in passing argument 2 of ‘wsConvert’ differ in signedness
interface.c: In function ‘guiGetEvent’:
interface.c:660: warning: implicit declaration of function ‘vcd_seek_to_track’
make[1]: *** [interface.o] Error 1
make[1]: Leaving directory `/Volumes/IBMama/Projects/svn.mplayerhq.hu/mplayer/gui'
make: *** [gui/libgui.a] Error 2
make: Leaving directory `/Volumes/IBMama/Projects/svn.mplayerhq.hu/mplayer'
# _
<<<<
Previously we were building just fine here. Not tested, but
building fine. I think the culprit is the sudden include of
stream/vcd_read.h for all platforms.
Of course darwin is listed in configure as a platform with a
functional [S]VCD subsystem. There really isn't any
auto-detection there for this feature. But vcd_read.h has
#ifdef that hard-codes a C #error message with further
platform restrictions.
I'm quite sure the GNU & other projects that provide [S]VCD
are working on darwin/osx, tho.
I hope we don't need to forcibly disallow darwin in configure.
Rather we should figure out a way to fix this.
Let me know if a detailed bugzilla report is needed.
Thank you for looking into this.
More information about the MPlayer-dev-eng
mailing list