[MPlayer-dev-eng] [PATCH] ddvnav+internal dvdread

[SciFi]

On Sun, 29 Apr 2007 14:04:58 +0200, Nico Sabbi wrote:
> Nico Sabbi wrote:
>> SciFi wrote:
>> 
>>> Hi,
>>> 
>>> On a related note, I asked on the dvdnav list why did they not choose
>>> to fork the libdvdnav2 (TWO) version.
>>> 
>>> ATPT the xine-lib project requires libdvdnav2, and we cannot have your
>>> forked version installed here because of missing symbols when linking
>>> xine-lib (1.1.6) against it due to your having chosen to fork the non-2
>>> version.
>> 
>> I didn't know of this problem. The changes can be applied to libdvdnav2
>> as well
>> 
>>> Hope that makes sense.  ;)
>>> 
>>> So the way I see it you *are* using the old libdvdnav version for the
>>> fork.  And I say yes let's get rid of it to prevent these conflicts,
>>> stop wasting time fixing this one, and get to work on the libdvdnav2
>>> tree which is already mirrored in your repo. Please.  ;)
> 
> I've just finished to apply all commits except the new build and header
> inclusion system (thus libdvdread is still integrated for the time
> being). Please, check and report if it works

So far so good.  I svn-up'd libdvdnav2 from your fork at r924,
builds fine.  Then xine-lib-1.1.6 configure can find it, and
builds fine, too.

They moved the xine-lib repo to a Mercurial server (uggg, YA-SCM,
I'm having their hg server give us bz2'd archives of their repo
instead), I've yet to try building the main 1.1 and 1.2 branches
with your new libdvdnav2, will do so asap...

I was about to build mplayer against it but we hit an unrelated snag
there (recent commits to gui/ gives us a hard-coded C #error now, am
trying to report it to this list but my post vaporised ;) ).

Let's see how your header massaging does.  ;)

Thanks.