[MPlayer-dev-eng] [PATCH] fix for v4l1 driver
voroshil at gmail.com
Sun Apr 29 01:45:50 CEST 2007
2007/4/29, Trent Piepho <xyzzy at speakeasy.org>:
> On Sat, 28 Apr 2007, Diego Biurrun wrote:
> > On Sat, Apr 28, 2007 at 03:54:06AM -0700, Trent Piepho wrote:
> > > This patch makes the v4l1 driver work properly. There were some bugs
> > > the kernel v4l1 compat system, but mplayer had some bugs too. This
> > > applies on top of the cosmetic patch I sent earlier.
> > I reindented the file, please resend an updated patch.
> Why couldn't you just apply my patch and then convert tabs to
> spaces? There
> are still indentation errors in the file that I already fixed once before.
> Here is a new (tab free) patch that re-fixes the indentation. I'll wait
> until this is done before generating a new fix patch, as I don't know of
> anyway to generate a new fix patch after a large white-space change other
> than to tediously redo the entire patch by hand, and I'd like to avoid
> that more than once.
Entire patch except following non-cosmetic change is applied:
>@@ -842,7 +841,7 @@
> ioctl(priv->video_fd, VIDIOCSWIN, &win);
>- // initialize video capture
>+ // initialize video sub-capture
> if (ioctl(priv->video_fd, VIDIOCCAPTURE, &one) == -1)
> mp_msg(MSGT_TV, MSGL_ERR, "FATAL: ioctl ccapture failed: %s\n", strerror(errno));
This change will be applied independently.
Thanks for the patch.
Vladimir Voroshilov mailto:voroshil at gmail.com
JID: voroshil at jabber.ru
More information about the MPlayer-dev-eng