[MPlayer-dev-eng] [PATCH] cosmetic patch for v4l1 driver
xyzzy at speakeasy.org
Sat Apr 28 20:08:45 CEST 2007
On Sat, 28 Apr 2007, Vladimir Voroshilov wrote:
> 2007/4/28, Diego Biurrun <diego at biurrun.de>:
> > On Sat, Apr 28, 2007 at 08:30:45PM +0700, Vladimir Voroshilov wrote:
> > > 2007/4/28, Trent Piepho <xyzzy at speakeasy.org>:
> > > >
> > > > mplayer's v4l1 driver didn't work with my cx88 card (v4l2) using the
> > > > kernel
> > > > v4l1 compat module. There were some bugs in the kernel v4l1 compat
> > > > system,
> > > > which I've fixed, but also some bugs in mplayer.
> > > >
> > > > The tvi_v4l.c has mostly 4 space indention, but there was a lot of
> > code
> > > > that used 3, 2, 1, or 0 spaces. I hate trying to read code with
> > RanDoM
> > > > indention, so here is a cosmetic patch that should make it 4 spaces
> > > > everywhere. I didn't re-format everything, just fix some things to
> > make
> > > > it
> > > > more readable.
> > > >
> > > Rejected. Patch contains mixed spaces and tabs.
> > > Either resend corrected patch or wait until i fix indentation myself
> > (i'll
> > > make it soon).
The existing file mostly used tabs & spaces for indention, so I didn't
I could have changed all the tabs to spaces, but that would have made the
patch much bigger.
> > I have the file with fixed indentation and no tabs in my local tree,
> > shall I commit?
> Do it right now.
More information about the MPlayer-dev-eng