[MPlayer-dev-eng] [PATCH] cosmetic patch for v4l1 driver

[Vladimir Voroshilov]

2007/4/28, Diego Biurrun <diego at biurrun.de>:
>
> On Sat, Apr 28, 2007 at 08:30:45PM +0700, Vladimir Voroshilov wrote:
> > 2007/4/28, Trent Piepho <xyzzy at speakeasy.org>:
> > >
> > > mplayer's v4l1 driver didn't work with my cx88 card (v4l2) using the
> > > kernel
> > > v4l1 compat module.  There were some bugs in the kernel v4l1 compat
> > > system,
> > > which I've fixed, but also some bugs in mplayer.
> > >
> > > The tvi_v4l.c has mostly 4 space indention, but there was a lot of
> code
> > > that used 3, 2, 1, or 0 spaces.  I hate trying to read code with
> RanDoM
> > > indention, so here is a cosmetic patch that should make it 4 spaces
> > > everywhere.  I didn't re-format everything, just fix some things to
> make
> > > it
> > > more readable.
> > >
> > Rejected. Patch contains mixed spaces and tabs.
> > Either resend corrected patch or wait until i fix indentation myself
> (i'll
> > make it soon).
>
> I have the file with fixed indentation and no tabs in my local tree,
> shall I commit?


Do it right now.


-- 
Regards,
Vladimir Voroshilov     mailto:voroshil at gmail.com
JID: voroshil at jabber.ru
ICQ: 95587719