[MPlayer-dev-eng] [PATCH] vo device for serdisplib controlled gfx displays / display modules (-vo serdisp)
albeu at free.fr
Mon Apr 23 17:13:18 CEST 2007
On Mon, 23 Apr 2007 00:00:07 +0200
Wolfgang Astleitner <wastl at liwest.at> wrote:
> i'd like to contribute a vo device for serdisplib controlled gfx
> displays / display modules.
> serdisplib is a library written by me for controlling generic display
> controllers, display modules, and gfx displays found in cellphones,
> photocopiers, etc.
> (monochrome, greyscale, colour).
I just had a quick look at the patch but there are some clear issues.
1. Don't use sws, a vo should just report the colorspaces it really support.
2. Don't use CONF_TYPE_FUNC, use normal suboptions or better use the
string passed to preinit() with the suboptions parser.
3. Why use dlopen at all? There are systems (and yes linux systems too)
that don't support dlopen. You can probably offer useing dlopen as an
alternative (although some will say its just cruft) but static linking
must be possible.
4. Use dioxygen compatibles comments when you document a function.
More information about the MPlayer-dev-eng