[MPlayer-dev-eng] [PATCH] demuxer and MP_NOPTS_VALUE

[Uoti Urpala]

On Fri, 2007-04-20 at 23:04 +0200, Christian Aistleitner wrote:
> However, libmpdemux/demuxer.c initializes ds->pts to 0 and not  
> MP_NOPTS_VALUE.

I think it shouldn't matter much what the initialization value is. It
might be used in some error case but 0 is probably no worse then. The
whole ds->pts field is kind of a hack.

>  Furthermore, fill_buffers handling does not respect pts of  
> MP_NOPTS_VALUE if correct_pts is not set.

Maybe it would be nicer if it always tested for MP_NOPTS_VALUE, but it
shouldn't matter with current code.

> Is my understanding of MP_NOPTS_VALUE flawed?

I think it's weird to talk about "understanding of MP_NOPTS_VALUE". It's
just a #define and there's not much to understand about it in isolation.
Not all uses of it need to have exactly the same semantics.