[MPlayer-dev-eng] Re: [PATCH] af_ambisonic

[Sebastian Olter]

Wed Apr 18 15:24:37 CEST 2007 Alex Beregszaszi:
> In the case you can't live without it, the proper place is at osdep/ for
> the strsep implementation. And don't forget adding configure checks.

As I've been told before (Rich Felker) strsep() might be risky on some
systems, so perhaps it's not so good idea to rely on their
implementations. My version is very short and proven to be safe; maybe
it will be better to leave it as file static.

Wed Apr 18 15:40:23 CEST 2007 Reimar Döffinger:
But did you (the "you" sending the patch) try if you can't just use the
subopt_parse from subopt-helper.c function for parsing??

I'll consider this but the Ambisonic options have an additional level
of complexity; throwing this out would result in something tricky like
af_pan, but much more complicated. I don't want to require users to
waste time for learning options; better let them learn how to properly
encode surround sound :P

Nico Sabbi: I'm sorry for that misindentation, it was gmail's fault, not mine.