[MPlayer-dev-eng] Re: [PATCH] af_ambisonic

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Wed Apr 18 15:40:23 CEST 2007


Hello,
On Wed, Apr 18, 2007 at 03:24:37PM +0200, Alex Beregszaszi wrote:
> > >> +#if defined(_WIN32) && !defined (__CYGWIN__)
> > >> +static char* strsep(char** haystack, char *needle)
> > > what does this do?
> > 
> > It was actually a surprise to see there is no strsep(3) in mingw, so I
> > reimplemented it.
> 
> In the case you can't live without it, the proper place is at osdep/ for
> the strsep implementation. And don't forget adding configure checks.

It really doesn't seem to be too important, using strchr probably won't
make things much more complicated.
But did you (the "you" sending the patch) try if you can't just use the
subopt_parse from subopt-helper.c function for parsing??

Greetings,
Reimar Döffinger



More information about the MPlayer-dev-eng mailing list