[MPlayer-dev-eng] [PATCH]?fix aspect stuff in widescreen monitors
Reimar.Doeffinger at stud.uni-karlsruhe.de
Mon Apr 16 16:55:51 CEST 2007
On Mon, Apr 16, 2007 at 04:20:14PM +0300, Onur K???k wrote:
> On Mon, 16 Apr 2007 10:15:04 +0200
> Reimar Doeffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:
> > Certainly not, the patch is nonsense, it duplicates the code for
> > monitorpixelaspect.
> I managed the patch that way, to respect the man page. In man page it
> says "monitorpixelaspect overrides monitoraspect".
Okay, but IMO there is no reason to keep it like that, it just ended
being like that because it made the implementation simpler.
> > It can be done by changing only 3 lines without adding any code
> > (changing default values of monitoraspect and monitorpixelaspect and
> > changing "if (monitorpixelaspect)" to "if (!monitoraspect)".
> I have made another patch according to the way you described. Though
> with this change, monitoraspect overrides monitorpixelaspect so man page
> needs to be updated too.
> If this is the way you prefer I can extend the patch to include a man
> page change. If not, please let me know how you prefer it.
Well, I don't object to this patch, esp. not one with man page update
:-). But I do not find it important either and thus hope some other developer
who cares will comment and apply.
More information about the MPlayer-dev-eng