[MPlayer-dev-eng] [PATCH] fix aspect stuff in widescreen monitors

[Reimar Doeffinger]

Hello,
On Mon, Apr 16, 2007 at 09:35:23AM +0200, Attila Kinali wrote:
> On Sat, 14 Apr 2007 21:11:30 +0300
> Onur Küçük <onur at delipenguen.net> wrote:
> 
> >  libvo/aspect.c assumes 4/3 monitor aspect ratio statically and unless
> > the user defines monitoraspect manually, video is played in wrong size
> > on widescreen monitors.
> 
> IMHO it's time to change the assumption of 4:3 monitor aspect
> to square pixel. The times when most people had monitors with
> 4:3 aspect are virtualy over.

Can also be done by adding monitorpixelaspect=1 to the config file

> IMHO this patch should be applied before RC2.

Certainly not, the patch is nonsense, it duplicates the code for
monitorpixelaspect. It can be done by changing only 3 lines without
adding any code (changing default values of monitoraspect and
monitorpixelaspect and changing "if (monitorpixelaspect)" to "if
(!monitoraspect)".

Greetings,
Reimar Doeffinger