[MPlayer-dev-eng] [PATCH] mencoder precised/exact seeking

Trent Piepho xyzzy at speakeasy.org
Thu Apr 12 02:57:10 CEST 2007

On Wed, 11 Apr 2007, Sam Wong wrote:
> This patch makes EDL seeking, -ss change to use the new code when
> -hr-edl-seek is enabled.

In some cases, it might not be desirable to have the edl code skip frames.
Some filters, like inverse telecine type fitlers, like to see every frame
in order since they look for patterns in the frames.  The current edl code
sends every frame to the filter stack during a skip, so the filters do
not see any breaks.

Of course this is very slow, and most filters don't care about missing
frames, so your patch is an improvement in almost all cases.

> I am still actively testing it, and I think it's stable enough for me to
> share. However, I never hack to mplayer code, so actually most of the
> work are just copy-and-paste without understanding much. I suspect there
> are some off-by-one-frame error inside, and I hope someone experienced
> could take a look at it. I believe this is a really nice to have

The current edl code has an off-by-one error.  If you create an EDL edit
point at frame X, then the edl code will randomly either edit on frame X or
frame X+1 depending on how the floating point values are rounded.

I have a relatively simple patch to fix this.

More information about the MPlayer-dev-eng mailing list