[MPlayer-dev-eng] [PATCH] rework of bsdb4848 detection code
voroshil at gmail.com
Wed Apr 11 07:42:37 CEST 2007
2007/4/11, Diego Biurrun <diego at biurrun.de>:
> On Tue, Apr 10, 2007 at 11:51:54PM +0700, Vladimir Voroshilov wrote:
> > Due to recent changes in *BSD BT848 headers detection code for tv://
> > I've also changed similar block for radio://
> > After this patch radio:// will use result of earlyer detection instead of
> > checking for the same thing.
> > Diego, is patch ok to commit?
> > P.S. I can't test it under *BSD, but it is not too complex and should work.
> > --- configure (revision 22963)
> > +++ configure (working copy)
> > @@ -6875,30 +6875,34 @@
> > -if bsd && test "$_radio" = yes && test "$_radio_bsdbt848" = auto ; then
> > +if bsd ; then
> > + if test "$_radio_bsdbt848" = auto && test "$_radio" = yes ; then
> I'd call that cosmetics. Is there a reason for this change?
> The rest looks OK. Either commit without this change or explain why you
> think it's an improvement.
Commited with removed cosmetics and fixed
"Checking for *BSD BrookTree 848 Radio interface header " message
("header" word removed).
Vladimir Voroshilov mailto:voroshil at gmail.com
JID: voroshil at jabber.ru
More information about the MPlayer-dev-eng