[MPlayer-dev-eng] Re: [PATCH] asf demuxer changes for dvr-ms

[John Donaghy]

> your quoting has the strangest look :)


I wish I knew what this means (something to do with gmail maybe?).

>
> > I'm not quite sure what you mean by this.
>
> I mean that you increase buffer+=N without checking
> that buffer don't overflow &buf[buf_len-1]


See if this is what you wanted.

>
> > - init_priv() can be made easier with calloc() + some assignments
> >


Done.

>
> > Actually Jon Elwood discovered that there are some 50fps dvr-ms files
> out
> > there and he sent me an update to my patch which I'll include when I
> resend
> > (if (((segment_marker & 0XF0) >> 4) == 6) then it's 50fps). I will
> change
> > the else clause to default to 60fps though as you suggest.


Also done.

Thanks,

John
-------------- next part --------------
A non-text attachment was scrubbed...
Name: asf_dvrms_a.patch
Type: application/octet-stream
Size: 18023 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20070410/6a2b58c4/attachment.obj>