[MPlayer-dev-eng] [PATCH] gmplayer fsFileSelect related fixes

[Sergey Pinaev]

On Tue, 10 Apr 2007 13:29:25 +1100
Vadim Pisarev <plv at farpost.com> wrote:

> >>>>> (btw, afaiu get_current_dir_name() returns malloc()ed string, that should
> >>>>> be free()d too)
> >>>> If so then that should be fixed..
> >>>        get_current_dir_name,  which  is  only  prototyped  if  _GNU_SOURCE  is
> >>>        defined, will malloc(3) an array big enough to hold the current  direc-
> >>>        tory  name.
> >> Uhg, so this is some nasty glibcism? Replace it with something
> >> portable then, like getcwd().
> > 
> > gui uses gtk/glib, so for consistency it should use g_get_current_dir() =)
> > 
> 
> So, should i replace get_current_dir_name() with g_get_current_dir()
> everywhere in Gui/mplayer.gtk/fs.c ?

imho yes.
and dont forget to free the mallocs!

-- 
mail="Sergey Pinaev <dfo at antex.ru>"
url="http://`echo $mail | sed 's/.* <\(.*\)@\(.*\)>/\1.\2/'`"