[MPlayer-dev-eng] Re: [PATCH] asf demuxer changes for dvr-ms

[Nico Sabbi]

John Donaghy wrote:
>>
>> > I can split this up into 4 patches:
>> > a) a patch to read the replicated data, to get timestamps, set key
>> frames
>> > and detect new video frames
>> > b) a patch to remove mpeg video codec parsing functions that are
>> redundant
>> > because of a)
>> > c) a patch to fix dvr-ms seeking
>> > d) a patch to improve audio codec detection
>> >
>> > Will that work?
>> >
>>
>> yes
> 
> 
> 
> OK. Here's the first patch which reads the dvr-ms replicated data 
> embeded in
> each packet.  It extracts the dvr-ms timestamps, sets key frames, detects
> new video frames, and deduces the average video frame time. Data before the
> first video key frame is thrown away which was deemed acceptable in an
> earlier post.
> 
> John
> 

uhm the most traumatic patch first, eh? :)

Premitting that I know nothing of asf in general I noticed the 
following issues:
- in get_ext_stream_properties() I'd prefer to have some more 
boundary checks against buf_len
- init_priv() can be made easier with calloc() + some assignments
- in get_payload_entension_data() defaulting to 50 fps is
   a bit nonsense (no one uses 50 fps, better default to 60
   that is surely much more used)
- did you notice if the three frame-type bits are always in the range 
[1..3] ?

since this code is executed only for dvr-ms I'm not opposed to commit 
this patch when those issues are fixed && if nothing breaks.

	Nico