[MPlayer-dev-eng] [PATCH] Remove ugly #include from tvi_bsdbt848.c
Diego Biurrun
diego at biurrun.de
Mon Apr 9 11:21:47 CEST 2007
On Mon, Apr 09, 2007 at 12:53:01AM +0700, Vladimir Voroshilov wrote:
> Hm. forgot to attach file.
>
> --- stream/tvi_bsdbt848.c (revision 22945)
> +++ stream/tvi_bsdbt848.c (working copy)
> @@ -38,20 +38,18 @@
>
> #include <sys/param.h>
> -#ifdef __NetBSD__
> -#include <dev/ic/bt8xx.h>
> +#ifdef USE_SUN_AUDIO
> #include <sys/audioio.h>
> #endif
Are you sure NetBSD does not need the first header?
> --- configure (revision 22945)
> +++ configure (working copy)
> @@ -6674,20 +6674,80 @@
>
> -if bsd; then
The test was under this check for a reason, why did you remove it? IMO
it should go around the header checks as well.
> @@ -6700,9 +6760,7 @@
> _noinputmodules="tv-bsdbt848 $_noinputmodules"
> fi
> echores "$_tv_bsdbt848"
> -fi #if bsd
>
> -
> echocheck "Video 4 Linux TV interface"
Don't remove that extra blank line, I like having tests separated by
more than just one line.
Diego
More information about the MPlayer-dev-eng
mailing list