[MPlayer-dev-eng] Re: [PATCH] one input key more commands

Diego Biurrun diego at biurrun.de
Sun Apr 1 15:49:45 CEST 2007


On Sun, Apr 01, 2007 at 03:39:24PM +0200, Ötvös Attila wrote:
> 2007. április 1. 15.11 dátummal Diego Biurrun ezt írta:
> > Try to match the style in the file.
> >
> > If in doubt, use the FFmpeg indentation style, i.e. 4 spaces for each
> > indentation level, no tabs.
> >
> > But it seems that you sent *two* patches, one with random indentation,
> > one with correct indentation.  Why?
> 
> I didn't decide that which indented was right: 2 spaces (input.c style) or 4 
> spaces ('default' style).
> Because I created 2 spaces indent in inpuz-section.patch (input.c style) and I 
> created 4 spaces indenz in input-section-4-indentation.patch ('default' 
> style) but this didn't work so thought.
> I'm sorry.

Please don't confuse us with multiple patches :)

Just resend the latest incarnation of your patch with proper 2 space
indentation like in the rest of input.c.

Diego



More information about the MPlayer-dev-eng mailing list