[MPlayer-dev-eng] [PATCH] vp7vfw encoding with compdata

[Gianluigi Tiesi]

On Sat, Mar 31, 2007 at 12:24:17PM +0200, Gianluigi Tiesi wrote:
> On Sat, Mar 31, 2007 at 10:44:31AM +0700, Vladimir Voroshilov wrote:
> > Hi.
> > 
> > 2007/3/31, Gianluigi Tiesi <mplayer at netfarm.it>:
> > >vp7vfw needs a call to CoUninitialize()
> > >to work when compdata is passed.
> > >Attached a patch that calls coinit/uninit
> > >I've restricted it to win32 since I think it will break something
> > >on unix.
> > >And yes it's not the better place to call it but calling it from
> > >ve_vfw.c crashes and messes up a lot of variable, I think it's
> > >related to the fact that gcc says something about calling convention
> > >(maybe not correctly defined in ve_vfw and correctly in mencoder.c?)
> > >
> > >-->
> > >Warning: resolving _CoInitialize by linking to _CoInitialize at 4
> > >Use --enable-stdcall-fixup to disable these warnings
> > >Use --disable-stdcall-fixup to disable these fixups
> > >
> > I'm not sure, but think that proper declaration of CoInitialize should fix 
> > this.
> > gcc does not add STDCALL to CoInitialize, AFAIK.
> > 
> > try to either declare it like this:
> > HRESULT STDCALL CoInitialize(PVOID)
> > or add
> > #include <ole2.h>
> > (where it is already defined)
> > into your source.
> > 
> I'll try it but I don't known where to put the uninitialize
> if moving the code
> Bye
> 
it would be fine to have it also on linux, but win32 loader
misses coinit and other com stuff, and looking at wine it doesn't seem
so trivial

Bye

-- 
Gianluigi Tiesi <sherpya at netfarm.it>
EDP Project Leader
Netfarm S.r.l. - http://www.netfarm.it/
Free Software: http://oss.netfarm.it/