[MPlayer-dev-eng] [PATCH] double click to switch to full screen in GUI

[Diego Biurrun]

On Thu, Sep 14, 2006 at 11:11:07PM +0200, laurent wozniak wrote:
> [...] 
> So, here is the patch that implements this behavior.

Been staring at your patch for a little more.  Looks good and works as
advertised.  I'll commit in a few days.

One more comment:

> --- Gui/interface.c	(revision 19814)
> +++ Gui/interface.c	(working copy)
> @@ -217,6 +218,10 @@
>   if ( autosync && autosync != gtkAutoSync ) { gtkAutoSyncOn=1; gtkAutoSync=autosync; }
>     
>   gtkInit();
> +// --- initialize some input constants 
> + g_object_get ( G_OBJECT ( gtk_settings_get_default() ), 
> +    "gtk-double-click-time", &double_click_time, NULL );
> + mp_input_set_double_click_time(double_click_time);

IIUC you're querying for the GTK default doubleclick time here.  I'm not
100% convinced this is what we want.  The GUI depends on GTK, but it's
not really a full-blown GTK application..

Diego