[MPlayer-dev-eng] [PATCH] False positive on pcm in mov samplerate hack

John Koleszar jkoleszar at on2.com
Thu Sep 28 20:30:41 CEST 2006


Hi all,


Attached patch fixes playback of a 5512Hz PCM audio track in a mp4 container
when using the mov demuxer. The lavf demuxer plays the sample correctly.

demux_mov.c has some hackish code that thinks arbitrarily low sample rates
(<7000) need to be adjusted. I can't find any samples that actually need the
fixup, so I can't fix this properly. Does anybody know what this code is trying
to work around? It's been in the tree practically forever.

Ripping the whole if() block out and fixing it Right once a broken sample is
found is IMO a better option, but in the mean time here's a patch that tries to
prevent these false positives.

Broken sample here:
ftp://opensource:opensource@ftp.on2.com/5512hz_pcm.mov

Thanks,

John
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: mov_pcm_samplerate_adjust.diff
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20060928/54059dc1/attachment.asc>


More information about the MPlayer-dev-eng mailing list