[MPlayer-dev-eng] [PATCH] verbosity reduction in streaming, input, CPU detection

[Diego Biurrun]

On Tue, Sep 26, 2006 at 11:00:37PM +0200, Roberto Togni wrote:
> On Sun, 24 Sep 2006 18:22:39 +0200
> Diego Biurrun <diego at biurrun.de> wrote:
> 
> > these are a couple of verbosity reduction patches I have accumulated
> > in my local tree.  I'd like to commit by the end of the week, comments
> > welcome.
> 
> > --- stream/network.c	(revision 19966)
> > +++ stream/network.c	(working copy)
> > @@ -440,7 +440,7 @@
> >        stream_cache_size =
> > (stream->streaming_ctrl->prebuffer_size/1024)*5;
> > if( stream_cache_size<64 ) stream_cache_size = 64;	// 16KBytes
> > min buffer }
> > -    mp_msg(MSGT_NETWORK,MSGL_INFO,MSGTR_MPDEMUX_NW_CacheSizeSetTo,
> > stream_cache_size);
> > +    mp_msg(MSGT_NETWORK,MSGL_V,"Cache size set to %d kBytes.\n",
> > stream_cache_size); }
> 
> This should stay

Why?  It's redundant information since it just echoes the value passed
on the command line, doesn't it?

> > --- stream/tcp.c	(revision 19966)
> > +++ stream/tcp.c	(working copy)
> > @@ -153,7 +153,7 @@
> >  #else
> >  	inet_ntop(af, our_s_addr, buf, 255);
> >  #endif
> > -	if(verb)
> > mp_msg(MSGT_NETWORK,MSGL_STATUS,MSGTR_MPDEMUX_NW_ConnectingToServer,
> > host, buf , port );
> > +	if(verb) mp_msg(MSGT_NETWORK,MSGL_V,"Connecting to server
> > %s[%s]: %d...\n", host, buf , port ); 
> 
> I think also this should stay there

But it's redundant:

MPlayer dev-SVN-r19982-4.1.2 (C) 2000-2006 MPlayer Team
Connecting to server www.nasa.gov[212.201.100.134]: 80...

Playing rtsp://a661.l1856741582.c18567.g.lr.akamaistream.net/live/D/661/18567/v0001/reflector:41582.
Connecting to server a661.l1856741582.c18567.g.lr.akamaistream.net[207.40.149.87]: 554...

The "Playing ..." line already conveys the interesting information, no
need to repeat it 2 times I'd say.

> > --- cpudetect.c	(revision 19966)
> > +++ cpudetect.c	(working copy)
> 
> Why?

Because it's not interesting information that might be useful outside of
debugging.  For me it prints

AltiVec found
CPU: PowerPC

Well, I knew what my CPU was already ..

Diego