[MPlayer-dev-eng] [PATCH] drag and drop handling - this fix has been ignored

[Diego Biurrun]

On Sat, Aug 19, 2006 at 05:06:52PM +0200, laurent wozniak wrote:
> 
> This fix has been ignored.
> Is there any problem with it, please ?
> Or it just get lost in the noise ?

Tested, applied.  Thanks for the patch.

Diego

> laurent wozniak wrote:
> >
> >The file drag and drop has not been working for a while, here is a 
> >very simple patch to correct this.
> >
> >Patch is included inline at the end.
> >
> >The symptom has already been described in another list:
> >
> >>From: Stephen Watson <stephen <at> kerofin.demon.co.uk>
> >>Subject: Two bugs in drag and drop to mplayer
> >>Newsgroups: gmane.comp.video.mplayer.user
> >>Date: 2005-11-30 18:31:43 GMT (35 weeks, 1 day and 12 minutes ago)
> >>
> >>I've found 2 bugs in mplayer's drag and drop handling.
> >>
> >>The first bug is when mplayer processes the passed urls it counts how 
> >>many
> >>valid ones it finds, then subtracts 1 for no reason. The result is 
> >>that if
> >>you drag N files, it plays N-1.  If you drag 1 it plays none.
> >
> >There is some history around this bug:
> >- 2004-03-20 12:46 AM: First, it has been introduced as a "fix" !
> >"fix: adds a file to many when d n' d."
> >Well, there were no problem. Now there is one: drag and drop is not 
> >working anymore since one file is missing.
> >I think this fix might have tried to compensate a bug somewhere else. 
> >But the original algorithm looks correct.
> >- 2004-03-25 10:49 PM: Commit on subversion: "wsxdnd.c" rev 12069
> >- 2004-09-21 03:37 PM: Problem reported in user list
> >- 2005-11-30 06:31 PM: Patch posted in wrong list (user list)
> >
> >I've tested the bug and the patch on: Linux / GNome / Fedora core 4
> >
> >--- /home/contrib/mplayer/mplayer/Gui/wm/wsxdnd.c    (revision 19294)
> >+++ /home/contrib/mplayer/mplayer/Gui/wm/wsxdnd.c    (working copy)
> >@@ -124,7 +124,7 @@
> >          /* Handle the files */
> >      if(wnd->DandDHandler){
> >-    wnd->DandDHandler(num-1,files);
> >+    wnd->DandDHandler(num,files);
> >      }
> >    }