[MPlayer-dev-eng] Re: vf_yadif.c: fix for (probably) older binutils

[Michael Niedermayer]

Hi

On Sun, Sep 24, 2006 at 10:48:30PM +0200, Tomas Janousek wrote:
> Michael Niedermayer napsal(a):
> >its ugly, id like to at least see the error message as gives and id like
> 
> The error message is:
> vf_yadif.s:131: Error: bad expression
> vf_yadif.s:131: Error: junk `1-1' after expression
> 
> The line is:
> movq -1-1(%ebx,%edx), %mm2
> 
> >to have the patch author confirm that mplayer and yadif work correctly
> >except this issue, there are plenty of -XYZ(something) in our code so
> >it seems odd that as would fail with -1-1 but work with 0-1-1 and -1
> 
> I didn't see any artifacts and I can confirm that the generated code, 
> when disassembled, is alright.

ok, then ive no objections to the patch ... unless someone knows a less
ugly solution (droping fedora support maybe ...)

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is