[MPlayer-dev-eng] [PATCH] Cleanup of TOOLS/cpuinfo.c

[Reimar Döffinger]

Hello,
On Tue, Sep 19, 2006 at 07:29:06PM +0800, Zuxy Meng wrote:
> 2006/9/19, Rich Felker <dalias at aerifal.cx>:
> >On Tue, Sep 19, 2006 at 01:33:14PM +0800, Zuxy Meng wrote:
> >> Convert strings to comments since they're never used.
> >
> >What about instead declaring the entries with a macro? Then the
> >strings could be omitted by the macro, but included later if we ever
> >decide we want them...
> 
> Good idea. Maybe this is better?

Looks fine to me, although strictly speaking

> -      char *desc;;
> -      char *description;
> +      char *desc;

>      static struct {
>        int bit;
> -      char *desc;;
> -      char *description;
> +      char *desc;

Removing the double ; is an unrelated cosmetic change...

Greetings,
Reimar Döffinger