[MPlayer-dev-eng] [PATCH] vf_yadif.c: forgotten emms/femms

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Fri Sep 22 11:17:01 CEST 2006


Hello,
On Fri, Sep 22, 2006 at 10:51:52AM +0200, Reimar D?ffinger wrote:
> On Thu, Sep 21, 2006 at 06:59:26PM -0400, Rich Felker wrote:
> > >      }
> > > +    asm volatile("emms \n\t" : : : "memory");
> > 
> > Is this protected inside proper ifdef?
> 
> yes, it is in the filter_line_mmx2, but performance-wise it might be
> better to move it to the filter function with appropriate #ifdef....

Thus I'd suggest this one instead...
I'll apply tomorrow if nobody comments...

Greetings,
Reimar Döffinger
-------------- next part --------------
Index: libmpcodecs/vf_yadif.c
===================================================================
--- libmpcodecs/vf_yadif.c	(revision 19923)
+++ libmpcodecs/vf_yadif.c	(working copy)
@@ -366,6 +366,9 @@
             }
         }
     }
+#if defined(HAVE_MMX) && defined(NAMED_ASM_ARGS)
+    if(gCpuCaps.hasMMX2) asm volatile("emms \n\t" : : : "memory");
+#endif
 }
 
 static int config(struct vf_instance_s* vf,


More information about the MPlayer-dev-eng mailing list