[MPlayer-dev-eng] [PATCH] make vo_caca work with newer libcaca

[Corey Hickey]

Gianluigi Tiesi wrote:
> On Thu, Sep 21, 2006 at 03:51:20PM -0700, Corey Hickey wrote:
>> Ah! Well then, that's nice. Good thing I didn't try to port vo_caca 
>> myself--I was thinking of doing so yesterday evening. :)
>>
>> I can't test that patch right now, but if it works, is there any reason 
>> to hold off on applying it? It looks like nobody reviewed the patch when 
>> it was sent:
>> http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/2006-August/045423.html
>> I don't really have the know-how to give it a proper review myself, but 
>> if nobody does by next week (when I may have time) I'll at least read it 
>> and do some thorough testing.
>>
>> -Corey
> 
> the new api code works fine, I suppose also the old should work too :P,
> but it's a bit difficult to find old caca in some systems :P
> As I said the best way is not adopt directly my current patch
> (on my page) since it's made to apply to the whole tree,
> instead look at mentioned link:
> http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/2006-August/045423.html
> (the splitted version of the patch)
> the first patch posted was v1.x only, then the author made it
> working with both versions but I've noticed the code is almost
> all different so the best way is split out in two files.

Right. I understand what you mean, I think. If/when I apply it, I can
use 'svn cp' to make vo_caca9.c (or maybe call it vo_caca09.c) and then
apply the changes to vo_caca.c. That way, both files will retain the
history.

Regardless, I'll make a more formal submission in several days.

-Corey