[MPlayer-dev-eng] [PATCH] Theora in Matroska

[Rich Felker]

On Wed, Sep 20, 2006 at 09:18:18PM +0400, Evgeniy Stepanov wrote:
> On Wednesday 20 September 2006 21:05, Reimar Döffinger wrote:
> > Hello,
> >
> > On Wed, Sep 20, 2006 at 04:02:00AM +0400, Evgeniy Stepanov wrote:
> > > this patch adds Theora video support to demux_mkv.
> > >
> > > I just copypasted a piece code without thinking. Seems to work. Please
> > > review :)
> >
> > Is this patch for -vc theora or -vc fftheora or both?
> 
> I have not yet seen a file that would work with fftheora. Every sample in 
> ftp://mplayerhq.hu/MPlayer/samples/ogg/Theora failes with
> [theora @ 0x865bef8]Missing extradata!
> message. -vc theora work fine with all of them.
> 
> Exactly the same happens with my patch: all these files (converted to mkv) 
> work with -vc theora but not -vc fftheora.
> 
> This patch does a very simple thing: unpacks 3 header packets from codec 
> private data and feeds them to the codec like regular packets. I'm not 

This is backwards and not allowed. The correct way is leaving them in
extradata. Passing them as regular packets will horribly break -ovc
copy and other things. Any patch that causes xiph-codec headers to be
sent as if they were data packets is automatically rejected.

Rich