[MPlayer-dev-eng] Re: [PATCH] MMX optimization for zrmjpeg driver

Karolina Lindqvist karolina.lindqvist at kramnet.se
Sun Sep 17 09:48:14 CEST 2006


lördag 16 september 2006 20:28 skrev rsnel at cube.dyndns.org:

> Thanks. I will test the patch and commit. I agree with vo_zr.c using the
> code in the zrmjpeg video filter (this decreases code duplication
> significantly). Keep the patches coming.

There is a one letter typo in the internet address, in the comment at the head 
of  jpeg_enc.h, it can be corrected in the patch, or it can be corrected in 
the doxygen white-space only patch.
You have to decide how you want it with the copyright notices, and if the 
header file should have one at all. The reason for the header file, is so 
that vo_zr.c can access the routines. Maybe the routines should be broken out 
from vf_zrmjpeg.c inte a separate file, like jpeg_enc.c for clarity? I did 
not do that, since you included everything into vf_zrmjpeg.c.

Karolina



More information about the MPlayer-dev-eng mailing list