[MPlayer-dev-eng] [PATCH] further dvr-ms playback improvements

John Donaghy johnfdonaghy at gmail.com
Sat Sep 16 19:58:35 CEST 2006


>
> There's a lot of cosmetic changes here. Please send them in a separate patch.

Without the changes to video.c the patch will have no effect. The
update to video.c involves putting a whole block of code inside a
conditional and consequently changing the indentation. Do you still
want a separate patch for this?

Also, I'm not sure it really is safe to change the behaviour for
MOV,FILM, VIVO and OGG but the existing code looks to me as though it
would ignore a fps value that was obtained from the container whereas
my version would honour it. I dont know if these other containers can
provide a fps though. I could resubmit (as 2 patches) with the video.c
change applied only to the ASF limb. Thoughts?

John



More information about the MPlayer-dev-eng mailing list