[MPlayer-dev-eng] Add demux_nut to libmpdemux

Rich Felker dalias at aerifal.cx
Fri Sep 15 19:30:03 CEST 2006


On Fri, Sep 15, 2006 at 03:48:37PM +0200, Diego Biurrun wrote:
> > > > --- Makefile	(revision 19814)
> > > > +++ Makefile	(working copy)
> > > > @@ -110,6 +110,7 @@
> > > >               $(X264_LIB) \
> > > >               $(MUSEPACK_LIB) \
> > > >               $(SPEEX_LIB) \
> > > > +             $(NUT_LIB) \
> > > 
> > > useless clutter
> > 
> > uhh... -lnut is necessary. If I had written a configure part, it would 
> > have done 'NUT_LIB=-lnut'.. Obviously now this is redundant, but it's a 
> > placeholder...
> 
> Then pass --with-extralibs, but don't clutter the Makefile needlessly.

???

This is for the -lnut not the -L/path/to/libnut...

> > > Below is a collection of long lines from demux_nut.c, I'd appreciate if
> > > you could make them look non-ugly on 80 char terminals.  This makes me
> > > think that 8 character indentation is excessive...
> > 
> > Good thing you're not in charge of NUT repo :) many lines there are ~150 
> > chars long...
> 
> Ugh, are you trying to compete with the Gui/ subdirectory?

LMAO. :)

> > Like I said, I just wanted to move out demux_nut.c from NUT repo, it's not 
> > exactly production ready.. Though it does work :)
> 
> Well, when is it going to be finally production ready then.  If you
> don't intend to finish it, how serious are you about NUT?
> 
> Seriously, NUT is supposedly frozen, but libnut does not even have an
> installation routine?  I don't know if I should laugh or cry ...

Hmm... how should it be installed I wonder?

Rich




More information about the MPlayer-dev-eng mailing list