[MPlayer-dev-eng] [PATCH] double click to switch to full screen in GUI

[Diego Biurrun]

On Thu, Sep 14, 2006 at 11:11:07PM +0200, laurent wozniak wrote:
> 
> Adam Tla?ka wrote:
> >So maybe this could be a good solution:
> >assign pause/unpase to single click event
> >assign fullscreen/window to double click event
> >
> >so in case of one double click action you have two single click events
> >and one double click event which means pause resize unpause actions
> >for example which could be acceptable IMHO
> 
> This join the generic idea of:
> Binding an arbitrary command to any mouse button X single click, if not 
> already bound,
> when the corresponding mouse button X double click is bound to a command.
> 
> Then, we have to put a name on this arbitrary command.
> 
> The do nothing command is transparent to the user.
> The pause command is not:
> If the user binds mouse 8 double click to some command, but when he 
> clicks on mouse 8, the screen pauses, he'll probably find this a bit 
> strange.
> 
> This is why I've implemented the arbitrary command as: do nothing.
> 
> Test case:
> - Mouse 1 double click is bound to full screen in configuration.
> - On initialization, mouse 1 click get bound to do nothing.
> - The user performs the following actions:
> - Mouse 1 single click, do nothing, mouse 1 double click, full screen.
> - Mouse 8 single click, log mouse 8 click not bound, mouse 8 double 
> click, log mouse 8 double click not bound.
> 
> So, here is the patch that implements this behavior.

OK, this is now working as expected.  Some comments:

You're making some changes to mouse wheel handling, this could go in a
separate patch.

Why not simply introduce a new command "nop", which we could then bind
to first button singleclick?  Then no extra logic is needed...

Diego