[MPlayer-dev-eng] Re: [PATCH] Fix to make zoran output work

[Guillaume POIRIER]

Hi,

On 9/15/06, Karolina Lindqvist <karolina.lindqvist at kramnet.se> wrote:
> fredag 15 september 2006 02:39 skrev Luca Barbato:
> > Karolina Lindqvist wrote:
> > > jpeg_enc.c retried.  zr now uses the jpeg_enc in the zrjpeg filter. The
> > > MMX optimizations are moved to there.
> >
> > could you put them in a separate file/directory please?
>
> If you mean the MMX code. Actually, it calls on existing routines already in
> mplayer. Specifically get_pixels() and vo_draw_alpha_yv12() .

The idea is to split arch-specific code in separate files.


> Both undocumented routines. Actually, the latter I am not exactly sure what it
> does in detail, but since everything is undocumented, and I have not been
> able to dig up all the details, and it works..... oh, well....  for the time
> being.

If you feel like it you can write doxygen comments about these
undocumented routines, if you figured out what they do.
Still, new code is supposed to be somewhat more documented, so if your
code could benefit from doxygen comments too, please add them.

Guillaume
-- 
With DADVSI (http://en.wikipedia.org/wiki/DADVSI), France finally has
a lead on USA on selling out individuals right to corporations!
Vive la France!