[MPlayer-dev-eng] [PATCH] Fix mplayer crash due to faad errors

[Giacomo Comes]

On Wed, Sep 13, 2006 at 10:27:38AM +0800, ?????? wrote:
> Hi,
> 
> On Wednesday 13 September 2006 02:37, Giacomo Comes wrote:
> > at the end of the encoding process mencoder will show many times these
> > messages: FAAD: error: Input data buffer too small, trying to resync!
> > FAAD: error: Unable to find ADTS syncword, trying to resync!
> > AAC_PROBE: 19 bytes
> > AUDIO PAYLOAD: f9 c 80 2a
> > AAC_PROBE: ret 0
> > and most of the times it will stop with a segmentation fault.
> 
> I think this is because mplayer still try to feed the decoder even if eof is 
> reached, ad_realaud.c used to have a similar bug, the solution there is to 
> check sh->ds->eof if sh->a_in_buffer_len<=0, and return instantly if eof is 
> reached. Maybe the same thing can be done to faad too.

I think it is not that simple.
I have to say that if I use as source a video that I download from the web
containing aac audio, I don't observe the messages reported above.
Only if I use as source a video with aac audio created with mencoder
then the above messages shoes up. And they get worst if the audio sample
rate is 32000Hz instead of 48000Hz.

My conclusion at the moment is that mencoder has some trouble making
movie with aac audio.

Someone with more knowledge should have a look at this.

Giacomo