[MPlayer-dev-eng] Improved remove-logo filter

[Uoti Urpala]

On Thu, 2006-09-14 at 00:53 -0700, Trent Piepho wrote:
> BTW, mplayer does require gcc 3/4, the vf_yadif.c filter that was just
> added uses the symbolic names for asm operands extension, which was added
> in gcc 3.1.

Actually not, it has code to disable asm under older gcc versions:

+#if __GNUC__ < 3 || (__GNUC__ == 3 && __GNUC_MINOR__ == 0)
+#undef HAVE_MMX
+#endif



I didn't read most of your patch but happened to see the following part:

+#ifdef HAVE_MMX2
+      stride -= logo_mask->width; /* go from _end_ of one line to _start_ of next line */
+      if (gCpuCaps.hasMMX2)
+       for (j = 0; j < logo_mask->height; j++, image += stride)
+         for (i = 0; i < logo_mask->width; i+=8, mask+=8, image+=8)
+            accumulator += MASKSUM8(image, mask);
+      else
+#endif

That looks suspicious, should that stride substraction really be in that
part of the code?