[MPlayer-dev-eng] [PATCH] further dvr-ms playback improvements

[Nico Sabbi]

John Donaghy wrote:

> I've been thinking about creating a new patch that will improve native
> dvr-ms playback in mplayer  with respect to jerky playback. I believe
> I can do this now without looking at the codec becasue I've found a
> way to extract the 'average time per frame' from the container for
> each stream.


very good. In your patch don't forget to document how it works, please

>
> I'm proposing using this value to deduce the framerate for the video
> stream and then modifying video.c at line 583 to only consider the pts
> if the fps is 1000. Ie if the asf parser can provide the fps then
> ignore the pts (note the fps isnt guaranteed to be there for all asf
> files because it is in the header extension object - but it is there
> for dvr-ms at least).
>
> Can anyone comment on whether or not this approach will be acceptable?
>
> On the subject of obtaining good pts values, I've tried very hard to
> see if they can be obtained from the container without success. There
> are pts values there but they are not precise enough for smooth
> playback though they seem ok for seeking. I've examined the replicated
> data included with each segment/payload but I cannot see an obvious
> pts value in there - there's no public documentation on what this data
> means so it's a bit hard to get anywhere with it.


not relying on the codec internals is always a good thing.
I'm sure you new patch will be bether than the previous ones, so please, 
post it.

Thanks

    Nico