patch review proceedings (was: Re: [MPlayer-dev-eng] [PATCH] make cache2.c readable)

Uoti Urpala uoti.urpala at pp1.inet.fi
Mon Sep 11 17:39:23 CEST 2006


On Mon, 2006-09-11 at 11:46 -0400, Rich Felker wrote:
> On Mon, Sep 11, 2006 at 03:26:18PM +0300, Uoti Urpala wrote:
> If it can cause a different binary to be generated then it DOES NOT
> BELONG IN A WHITESPACE ONLY PATCH!
> 
> Even if it can't, changes which are not whitespace STILL DO NOT BELONG
> IN PATCHES THAT CLAIM TO BE WHITESPACE CHANGES ONLY!!!
> 
> Stop this stupidity. Rejecting the patch was correct.

As the original patch submitter already said once, it was not supposed
to be a "WHITESPACE ONLY PATCH", and there was no "CLAIM" that it was
either.




More information about the MPlayer-dev-eng mailing list