[MPlayer-dev-eng] [PATCH] make cache2.c readable

Rich Felker dalias at aerifal.cx
Mon Sep 11 07:27:13 CEST 2006


On Sun, Sep 10, 2006 at 04:20:02PM -0400, The Wanderer wrote:
> Uoti Urpala wrote:
> 
> >On Sun, 2006-09-10 at 15:26 -0400, The Wanderer wrote:
> >
> >>Denis Vlasenko wrote:
> 
> >>>I didn't say "only whitespace" change. I said "No real code
> >>>changes".
> >>
> >>For one thing, how is changing a variable declaration to no longer
> >>initialize the variable (when it will in fact be used before being
> >>written to) not a real code change?
> >
> >Because it doesn't change the declaration to "no longer initialize
> >the variable". Static variables are initialized to 0 by default.
> 
> ...live and learn...
> 
> Somehow I'd managed to make it this far in life without noticing that.
> My bad.

Nonetheless they are not equivalent in any real world compiler.
(Explicitly) initialized data (even if it's 0) goes in data segment.
Implicitly zero data goes in bss. This IS a change to the code for
practical purposes even if the C standard does not require it to be
treated as such.

Rich





More information about the MPlayer-dev-eng mailing list