[MPlayer-dev-eng] [PATCH] make cache2.c readable (was:"lockless" cache2 looks buggy)

[Diego Biurrun]

On Sun, Sep 10, 2006 at 08:57:16PM +0200, Denis Vlasenko wrote:
> On Thursday 31 August 2006 20:23, Diego Biurrun wrote:
> > On Sun, Aug 27, 2006 at 03:48:01PM +0200, Denis Vlasenko wrote:
> > > 
> > > Patch makes indentation consistent and adds
> > > some whitespace so that code is easier to read.
> > > Some long lines wrapped.
> > > 
> > > No real code changes.
> > > 
> > > --- cache2.0/stream/cache2.c	2006-08-18 20:30:35.000000000 +0200
> > > +++ cache2.1/stream/cache2.c	2006-08-21 20:15:43.000000000 +0200
> > > @@ -35,333 +35,347 @@ int stream_seek_long(stream_t *s,off_t p
> > >  
> > > -static int min_fill=0;
> > > +static int min_fill;
> > 
> > This is more than a whitespace change, patch rejected.  Whitespace
> > changes must not be mixed with other changes.
> 
> I didn't say "only whitespace" change. I said "No real code changes".

And I said "Whitespace changes must not be mixed with other changes.".

> But nevermind. I am not interested anymore in sending
> any sort of patch to this project.

Patch senders already outnumber reviewers by about 10:1 or more.  If you
cannot play by the rules, tough luck.  I'll go find somebody else's
patch to look at, the queue is practically infinite...

Diego