[MPlayer-dev-eng] [PATCH] make cache2.c readable

[The Wanderer]

Denis Vlasenko wrote:

> On Thursday 31 August 2006 20:23, Diego Biurrun wrote:
> 
>> On Sun, Aug 27, 2006 at 03:48:01PM +0200, Denis Vlasenko wrote:
>> 
>>> Patch makes indentation consistent and adds
>>> some whitespace so that code is easier to read.
>>> Some long lines wrapped.
>>> 
>>> No real code changes.
>>> 
>>> --- cache2.0/stream/cache2.c	2006-08-18 20:30:35.000000000 +0200
>>> +++ cache2.1/stream/cache2.c	2006-08-21 20:15:43.000000000 +0200
>>> @@ -35,333 +35,347 @@ int stream_seek_long(stream_t *s,off_t p
>>> 
>>> -static int min_fill=0;
>>> +static int min_fill;
>> 
>> This is more than a whitespace change, patch rejected.  Whitespace
>> changes must not be mixed with other changes.
> 
> I didn't say "only whitespace" change. I said "No real code changes".

For one thing, how is changing a variable declaration to no longer
initialize the variable (when it will in fact be used before being
written to) not a real code change?

For another, whitespace is not the only possible kind of cosmetic issue,
and all cosmetics are required to be in separate patches from any other
type of change. Even if you had added a "min_fill = 0;" line elsewhere,
to keep the same functionality, it would still have been a cosmetic
change and hence would have been unacceptable.

I believe you had been told already that cosmetics must not be mixed
with any other kind of change. Why, then, make any non-cosmetic change
of any sort whatsoever in what is avowedly a cosmetics patch?

> But nevermind. I am not interested anymore in sending any sort of
> patch to this project.

I, for one, consider this somewhat unfortunate... the requirements
really aren't that onerous for the most part, just perhaps a bit
unexpected. You do seem (at least to my somewhat inexperienced eye) the
sort to be able to provide competent contributions, but you don't seem
willing to accept the reasons why these things are required. (Somehow
this paragraph doesn't quite say what I wanted it to...)

-- 
       The Wanderer

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

Secrecy is the beginning of tyranny.