[MPlayer-dev-eng] Re: [PATCH] TimecodeScale handling in matroska

[Evgeniy Stepanov]

On Friday 08 September 2006 20:41, Evgeniy Stepanov wrote:
> Hi,
>
> current matroska demuxer has several problems with files whose
> TimecodeScale value is different from default (1000000). With TimecodeScale
> of 500000: - displayed movie duration is 2 times bigger that it should be;
> - scrolling forward works as expected: x -> x+10, but scrolling backwards
> halves the current pts: x -> x / 2.
>
> Suggested demuxer modifications:
>
> 1. If TimecodeScale element comes before Duration element, duration value
> will be calculated using wrong tc_scale. mkv-tc_scale.patch fixes this.
>
> 2. According to specs, BlockDuration is based on TimecodeScale, hence
> mkv-tc_scale2.patch. I have not noticed any effect from this change.
>
> 3. Index entries (CueTime) are not based on TimecodeScale according to
> specs, but they definitely are in the sample I have. mkv-tc_scale3.patch
> deals with this.

Ok, if no one cares, I'm going to commit it on Tuesday.

It's almost harmless: it changes nothing if TimecodeScale is default not 
specified. Files with non-default TimecodeScale work clearly better with 
these patches than before.