[MPlayer-dev-eng] [PATCH] use dvdnav's dvdread (for menu selection)

Corey Hickey bugfood-ml at fatooh.org
Sun Sep 10 00:01:10 CEST 2006


Nico Sabbi wrote:
> Nico Sabbi wrote:
> 
>> In short: dvdnav is installed with its own old version of dvdread, 
>> that is the only
>> library working when selecting menu items; stream_dvd.c can reuse this 
>> version
>> of dvdread.
>>
>> This patch changes configure (and to a lesser extent stream_dvd.h) 
>> modifying the
>> order of detection:
>> 1) dvdnav
>> 2) mpdvdkit
>> 3) dvdread
>>
>> when dvdnav is yes it will disable mpdvdkit and set dvdread to yes, 
>> but without
>> adding -ldvdread to the compilation switches.
>>
>> I preferred to add the changes to stream_dvd.h rather than adding 
>> -Idvdread to the
>> include path because in the future separating the configuration cases 
>> will be easier.
>>
>> If no one objects I'll commit this patch soon.
>>
>> ------------------------------------------------------------------------
>>
>> Index: stream/stream_dvd.h
>> ===================================================================
>> --- stream/stream_dvd.h	(revisione 19602)
>> +++ stream/stream_dvd.h	(copia locale)
>> @@ -6,6 +6,11 @@
>> #include "libmpdvdkit2/ifo_types.h"
>> #include "libmpdvdkit2/ifo_read.h"
>> #include "libmpdvdkit2/nav_read.h"
>> +#elif USE_DVDNAV
>>  
>>
> 
> this should read #elif defined(USE_DVDNAV).
> committed.

Is there a way for configure to check whether libdvdread has encrypted
DVD support? I almost filed a bug just now before I realized Debian's
libdvdread is broken that way.

-Corey



More information about the MPlayer-dev-eng mailing list