[MPlayer-dev-eng] Solaris patches

Robin KAY komadori at gekkou.co.uk
Mon Sep 4 16:08:50 CEST 2006


Michael Niedermayer wrote:
[snip]

> the change to yuv2rgb.c is wrong and rejected, please read
> DOCS/tech/colorspaces.txt

Ah! I picked up on the difference between the in-memory ordered and 
in-register ordered formats, but not that the order of the letters 
didn't match the register order.

http://www.blastwave.org/~komadori/patches/mplayer-head-20060902-fix-broken-colours-2.diff

BTW, isn't the inline conditional used to set bpp in yuv2rgb.c the wrong 
way around then? I know both the depth macros have the same definition.

[snip]

> you mean ptr[0] | (ptr[1] << 8) ?

Yes.

-- 
Wishing you good fortune,
Robin KAY (komadori)



More information about the MPlayer-dev-eng mailing list