[MPlayer-dev-eng] Solaris patches

[Robin KAY]

Dominik 'Rathann' Mierzejewski wrote:

> Robin KAY wrote:
>
>> http://www.blastwave.org/~komadori/patches/mplayer-1.0pre8-fix-big-endian-colours.diff
>> http://www.blastwave.org/~komadori/patches/mplayer-head-20060902-fix-big-endian-colours.diff
>>
>> Fixes swapped red and blue channels in video output on SPARC.
>
[snip]

> Cosmetics, rejected.

[snip]

> Mixed cosmetics and functional.

http://www.blastwave.org/~komadori/patches/mplayer-head-20060902-fix-big-endian-colours_NOCOSMETICS.diff

>> http://www.blastwave.org/~komadori/patches/mplayer-1.0pre8-fix-solaris8-errors.diff
>> http://www.blastwave.org/~komadori/patches/mplayer-head-20060902-fix-solaris8-errors.diff
>>
>> Fixes building under Solaris 8.
>
> What errors does this fix?

vorbis.c: uint_fast64_t is not available.
cookies.c: SIZE_MAX requires <limits.h>.

With vorbis.c, the patch simply changes uint_fast64_t to uint64_t. As 
the patches were ported from pre8 to head for your convenience, I did 
not notice that head now appears to supply (u)int_fastXX_t typedefs if 
they are missing. I have therefore removed this change from the patch 
against head.

>> http://www.blastwave.org/~komadori/patches/mplayer-1.0pre8-fix-unaligned-read.diff
>> http://www.blastwave.org/~komadori/patches/mplayer-head-20060902-fix-unaligned-read.diff
>>
>> Fixes a crash on SPARC in the ASF demuxer.
>
[snip]

> Mixed cosmetics with functional. Rewording a comment *is* considered 
> cosmetics.

http://www.blastwave.org/~komadori/patches/mplayer-head-20060902-fix-unaligned-read_NOCOSMETICS.diff

-- 
Wishing you good fortune,
Robin KAY (komadori)